[try] Record failed e2e tests as artifacts #26959
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamziel
commented
Nov 13, 2020
| format: 'png', | ||
| everyNthFrame: 1, | ||
| } ); | ||
| session.on( 'Page.screencastFrame', ( event ) => { |
There was a problem hiding this comment.
do we need to register a new listener for every started test? do they get cleared on stopScreencast?
|
Size Change: 0 B Total Size: 1.19 MB ℹ️ View Unchanged
|
|
I believe cypress supports this out of the box. Not sure if it uses puppeteer though, might need to further investigate. |
Just noting that we used to use Cypress but moved away from it, see #5618. |
|
Now that we have Playwright, achieving this goal should be easier. I'm closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an exploratory PR to record mp4 videos of failed e2e tests, inspired by this comment by @noahtallen:
#26664 (review)
It captures png screenshots using chrome devtools protocol, stores them on disk, and uses ffmpeg to encode an mp4 video.
Concerns:
ffmpeg?cc @noahtallen @noisysocks @talldan @gziolo @draganescu