-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Site Editor: Show document title on small screens with nav sidebar open #27051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattwiebe
added
[Type] Bug
An existing feature does not function as intended
[Feature] Full Site Editing
labels
Nov 17, 2020
mattwiebe
requested review from
vindl,
Copons,
david-szabo97,
jeyip,
noahtallen and
Addison-Stavlo
November 17, 2020 21:10
Size Change: +94 B (0%) Total Size: 1.19 MB
ℹ️ View Unchanged
|
noahtallen
approved these changes
Nov 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm yeah, I'll commit this and open an issue for broader support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are still some things to clean up for responsive views. The document title would previously be totally hidden when browsing templates in the nav sidebar.
Fixes #26755
How has this been tested?
Screenshots
^ Before
^ After
Types of changes
Checklist: