Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure phpunit-watcher to improve devex. #27058

Merged
merged 1 commit into from
Nov 23, 2020

Conversation

iandunn
Copy link
Member

@iandunn iandunn commented Nov 18, 2020

Description

phpunit-watcher provides similar features for PHP tests that Jest provides for JavaScript tests.

How has this been tested?

  1. composer update
  2. composer run test:watch or composer run test:watch -- --group=restapi
  3. Change a file in lib/ or phpunit/. You should see the tests re-run.

Types of changes

New feature

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

This provides similar features for PHP tests that Jest provides for JavaScript tests.

The `process-timeout` option is disabled so that phpunit-watcher can run indefinitely. See spatie/phpunit-watcher#63 (comment)".
@iandunn
Copy link
Member Author

iandunn commented Nov 20, 2020

It looks like CODEOWNERS doesn't have anyone listed for /phpunit, so pinging a few folks from related components: @ntwb, @spacedmonkey, @nosolosw

@oandregal oandregal requested a review from a team November 20, 2020 09:49
Copy link
Member

@ntwb ntwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having watched and followed the upstream issue relating to this PR, looks good to me @iandunn

@draganescu draganescu merged commit 39dbdd2 into WordPress:master Nov 23, 2020
@github-actions github-actions bot added this to the Gutenberg 9.5 milestone Nov 23, 2020
@iandunn
Copy link
Member Author

iandunn commented Nov 23, 2020

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants