Template/site editor: prevent classic block from loading #27059
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +291 B (0%) Total Size: 1.19 MB
ℹ️ View Unchanged
|
6 tasks
|
Some unit tests fail: It looks like this file needs to include more mocks: gutenberg/test/unit/__mocks__/@wordpress/block-library.js Lines 2 to 3 in 273dee2 |
gziolo
added
[Feature] Full Site Editing
[Block] Classic
david-szabo97
requested changes
Nov 19, 2020
Comment on lines
+90
to
+92
| const isClassicEnabled = | ||
| window.wpEditorL10n && window.wp && window.wp.oldEditor; | ||
|
|
There was a problem hiding this comment.
These values might change during runtime so a function would work better here. This would fix the tests too.
Suggested change
| const isClassicEnabled = | |
| window.wpEditorL10n && window.wp && window.wp.oldEditor; | |
| const isClassicEnabled = () => | |
| window.wpEditorL10n && window.wp && window.wp.oldEditor; | |
| @@ -139,7 +142,7 @@ export const __experimentalGetCoreBlocks = () => [ | |||
| embed, | |||
| file, | |||
| group, | |||
| window.wp && window.wp.oldEditor ? classic : null, // Only add the classic block in WP Context | |||
| isClassicEnabled ? classic : null, // Only add the classic block in WP Context | |||
There was a problem hiding this comment.
Suggested change
| isClassicEnabled ? classic : null, // Only add the classic block in WP Context | |
| isClassicEnabled() ? classic : null, // Only add the classic block in WP Context |
| @@ -182,7 +185,7 @@ export const registerCoreBlocks = ( | |||
| blocks.forEach( registerBlock ); | |||
|
|
|||
| setDefaultBlockName( paragraph.name ); | |||
| if ( window.wp && window.wp.oldEditor ) { | |||
| if ( isClassicEnabled ) { | |||
There was a problem hiding this comment.
Suggested change
| if ( isClassicEnabled ) { | |
| if ( isClassicEnabled() ) { |
ellatrix
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See #26915.
Currently the classic block is available in the site editor and triggers an error when loading because
window.wpEditorL10nis not set.In the site editor, ideally any scripts for the classic editor should not load and the block should not be available.
If there is free form content in the post content, the content can be previewed through the missing block mechanism.
How has this been tested?
Screenshots
Types of changes
Checklist: