Generalize the atom family concept as an atom selector concept instead #27147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Package] Data
16 tasks
|
Size Change: +25 B (0%) Total Size: 1.2 MB
ℹ️ View Unchanged
|
|
This is a blocker for me for #27140 and since it's just an improvement of the existing family concept, I'm going to land it. Happy to address any follow-up comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #27140 I discovered that the atom family concept was not enough to handle all kinds of selectors. This PR removes that concept and replace it with a simpler and more generic atom selector one.
Basically, the old atom family items were just selectors with a single argument.
I added a unit test to cover the new addition.
I also tweaked the atomic stores creations to accept only "atom selectors" on the "selectors" key. This makes sure all selectors are made performant by default.