-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Full Site Editing: Update the template parts admin list with new columns and views #27156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: 0 B Total Size: 1.2 MB ℹ️ View Unchanged
|
david-szabo97
approved these changes
Nov 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Templates and template parts are working great. New columns and views are there. Search works. Creating a new template part works. Editing existing template part works.
✅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We've recently updated the
wp_template
admin list with more columns and views to show all the available templates, with more informations (such as their corresponding theme, or if they were originally provided as files).This PR adds the same features to the
wp_template_part
.To avoid duplicating a lot of code, or having hooks for one post type in the file registering the other, I've moved the callbacks functions in a separate utilities file.
How has this been tested?
/wp-admin/edit.php?post_type=wp_template_part
./wp-admin/edit.php?post_type=wp_template
) for regressions.Screenshots
Types of changes
New feature (non-breaking change which adds functionality)
Checklist: