Fixes a regression in setting the font-size of the code block #27862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
added
[Block] Code
|
Size Change: -33 B (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
mkaz
approved these changes
Dec 22, 2020
There was a problem hiding this comment.
Your changes looks good and makes sense.
However, it does not fix the issue with the TwentyTwentyOne theme because it hard codes the default font size for code block to the xs size by specifying:
.wp-block-code code {
font-size: var(--global--font-size-xs);
}
|
@mkaz I've commented about the issue with the TwentyTwentyOne theme over there #27827 (comment) |
|
Thanks for fixing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27827
#27294 introduced the font size support for the code block. It also added these styles to the block's CSS:
This was problematic so in #27672 the CSS Custom Property was removed. However, that PR didn't remove the whole declaration, only removed the CSS Custom Property, hence introduced a regression. This is the current CSS of the block:
#27672 should have removed the font-size declaration from the code block's CSS instead.