-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Update Document settings name to Post/Page. #28067
Conversation
Current: The sidebar has two tabs, Document and Block: New: The sidebar has two tabs, Post/Page and Block: Current: - The **Document Tab** shows metadata and settings for the post or page being edited. New: - The **Post/Page Tab** shows metadata and settings for the post or page being edited.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, I'm game to have this merged without the screenshot being updated but ideally both can be handled within this same PR.
@@ -41,9 +41,11 @@ Please note that selection and focus can be different. An image block can be sel | |||
 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A new screenshot is needed to correspond with these changes to the text as well otherwise it'll be confusing to have differing names here. Not quite sure who might able to make this happen.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found the Figma file and made a duplicate. Then edited the screen.
I am thinking it is Mark who have made these screens.
@mapk
Let's get some feedback from him on these adjustments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me fwiw!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not heard anything from Mark, so I say let's go for it..:)
(I also posted in the design Slack channel to get some last minute comments, but in general it seems that everything is alright.)
Why would you want to make the generic "Document" more specific? So it won't be correct for custom post types? Or did you use the post type label? |
Looks good. For custom post types, it would be nice if it said "Post" or the post type label. Document feels a bit too generic and likely does not mean much to people. One request in the future is to have clear before+after screenshots to make these easier/quicker to review. |
First off I apologize as I have a feeling that I was not totally clear on what this PR is about. It was created more of a spur of the moment to adjusting documentation. https://make.wordpress.org/test/2020/12/23/fse-program-testing-call-1-template-editing/ As the sidebar tab name Document has changed in Gutenberg to Page/Post. I added this PR to change the image used in the settings-sidebar documentation page as the text used just below the image in the above settings sidebar page. Current screen located in the documentation: (Text below the screen.)
New screen that needs to replace the above: (New text below the screen.)
|
I found this merged PR: (From the above PR description.) |
The sidebar Document settings name have changed to Post while in a post, and Page while in a Page.
Current: The sidebar has two tabs, Document and Block:
New: The sidebar has two tabs, Post/Page and Block:
Current: - The Document Tab shows metadata and settings for the post or page being edited.
New: - The Post/Page Tab shows metadata and settings for the post or page being edited.