Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Update Document settings name to Post/Page. #28067

Closed
wants to merge 1 commit into from
Closed

Docs: Update Document settings name to Post/Page. #28067

wants to merge 1 commit into from

Conversation

paaljoachim
Copy link
Contributor

The sidebar Document settings name have changed to Post while in a post, and Page while in a Page.

Current: The sidebar has two tabs, Document and Block:
New: The sidebar has two tabs, Post/Page and Block:

Current: - The Document Tab shows metadata and settings for the post or page being edited.
New: - The Post/Page Tab shows metadata and settings for the post or page being edited.

Current: The sidebar has two tabs, Document and Block:
New: The sidebar has two tabs, Post/Page and Block:

Current: - The **Document Tab** shows metadata and settings for the post or page being edited.
New: - The **Post/Page Tab** shows metadata and settings for the post or page being edited.
Copy link
Contributor

@annezazu annezazu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, I'm game to have this merged without the screenshot being updated but ideally both can be handled within this same PR.

@@ -41,9 +41,11 @@ Please note that selection and focus can be different. An image block can be sel
![Settings Sidebar](https://cldup.com/iAqrn6Gc8o-3000x3000.png)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new screenshot is needed to correspond with these changes to the text as well otherwise it'll be confusing to have differing names here. Not quite sure who might able to make this happen.

Copy link
Contributor Author

@paaljoachim paaljoachim Jan 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found the Figma file and made a duplicate. Then edited the screen.

04-Sidebar

I am thinking it is Mark who have made these screens.
@mapk

Let's get some feedback from him on these adjustments.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me fwiw!

Copy link
Contributor Author

@paaljoachim paaljoachim Jan 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not heard anything from Mark, so I say let's go for it..:)
(I also posted in the design Slack channel to get some last minute comments, but in general it seems that everything is alright.)

@joyously
Copy link

Why would you want to make the generic "Document" more specific? So it won't be correct for custom post types? Or did you use the post type label?

@kellychoffman
Copy link
Contributor

Looks good.

For custom post types, it would be nice if it said "Post" or the post type label. Document feels a bit too generic and likely does not mean much to people.

One request in the future is to have clear before+after screenshots to make these easier/quicker to review.

@paaljoachim paaljoachim changed the title Update Document settings name to Post/Page. Docs: Update Document settings name to Post/Page. Jan 14, 2021
@paaljoachim
Copy link
Contributor Author

paaljoachim commented Jan 14, 2021

First off I apologize as I have a feeling that I was not totally clear on what this PR is about. It was created more of a spur of the moment to adjusting documentation.

https://make.wordpress.org/test/2020/12/23/fse-program-testing-call-1-template-editing/
Step 8. "While in the editor for the post, navigate to the Post Tab of the Settings Sidebar (previously called Document). ......"
Links to this page: https://developer.wordpress.org/block-editor/designers/user-interface/#settings-sidebar

As the sidebar tab name Document has changed in Gutenberg to Page/Post. I added this PR to change the image used in the settings-sidebar documentation page as the text used just below the image in the above settings sidebar page.

Current screen located in the documentation:
Sidebar-WordPress-old-Document-tab

(Text below the screen.)
The sidebar has two tabs, Document and Block:

  • The Document Tab shows metadata and settings for the post or page being edited.

New screen that needs to replace the above:
04-Sidebar

(New text below the screen.)
The sidebar has two tabs, Post/Page and Block:

  • The Post/Page Tab shows metadata and settings for the post or page being edited.

@paaljoachim
Copy link
Contributor Author

paaljoachim commented Jan 15, 2021

@joyously and @kellychoffman

I found this merged PR:
Use Post Type label for Document tab in Settings Header
#17311

(From the above PR description.)
"This PR initially started as ability to filter the Document label in the sidebar. I needed to be able to rename that label in my project. So that I could differentiate between different post types and custom post types as well. It could also be a generic custom label e.g., Article, Story etc. for any specific newsroom."

@skorasaurus skorasaurus added the [Type] Developer Documentation Documentation for developers label Feb 9, 2021
Base automatically changed from master to trunk March 1, 2021 15:45
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants