[RNMobile/iOS] Correct autoscroll to be enabled when the keyboard is going to appear #28352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +137 B (0%) Total Size: 1.29 MB
ℹ️ View Unchanged
|
antonis
requested changes
Jan 20, 2021
There was a problem hiding this comment.
Hello @lukewalczak 👋
The code changes LGTM 👍
I'm still able to reproduce the issue using WPiOS (tested latest dev) with the following steps (recording):
- Run the app
- Press the floating button at the bottom
- Select Site page
- Scroll down to the Home pages category and select the third design (or any design with enough content)
- Press Create Page
- Scroll to the Specialty Items header and set focus
- Press the alignment button
- Notice that the issue is reproduced
I tested this on an iPhone SE 2020 with iOS 14.2 and on iOS 11 emulator.
antonis
approved these changes
Jan 20, 2021
There was a problem hiding this comment.
Great work @lukewalczak 👍
I tested this using the WPiOS app on an iPhone SE 2020 with iOS 14.2 and the fix works as expected. I also did a quick sanity check with WPAndroid.
The code changes are consistent and LGTM 🎉
lukewalczak
added
Mobile App - i.e. Android or iOS
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: wordpress-mobile/gutenberg-mobile#3024
How has this been tested?
1.Open a post/page for editing
2.Focus on a heading block that is near the bottom of the screen
3.Notice that the heading block scrolls up to become visible above the keyboard
4.Press the alignement button
5.Notice that the heading block scrolls back behind the alignment actionsheet
Screenshots
Types of changes
Checklist: