Padding Edit: Fix handling of custom unit theme setting #28603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ItsJonQ
added
[Type] Bug
|
Size Change: -36 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
oandregal
approved these changes
Feb 2, 2021
oandregal
force-pushed
the
fix/padding-edit-no-custom-unit
branch
from
50c0807
to
76bee52
Compare
|
I see there are some test failures that were related to the PHP version in use and that are fixed on master. I've gone ahead and rebased this PR so it's ready to land as soon as tests pass. @noisysocks This is a fix to something that's not a regression in 9.9, it existed prior. However, it's still a nice fix to land in 5.7. Not sure how should we go about it? Should we port it to the Gutenberg 9.9 release or should we wait and port it to WordPress 5.7 beta as a bugfix later? |
|
Meanwhile I can confirm that if If a block padding is first created with a custom unit, and the theme support is removed, -picture switching themes, |
aristath
approved these changes
Feb 3, 2021
oandregal
added
the
Backport to WP 6.7 Beta/RC
|
Tagging this to "backport to beta" as per this comment. |
|
Yep, add the backport label (you did it!) and I will include it in one of the 5.7 betas. |
noisysocks
pushed a commit
that referenced
this pull request
Feb 7, 2021
noisysocks
pushed a commit
that referenced
this pull request
Feb 8, 2021
noisysocks
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update fixes the
Paddingstyle controls as it relates to thecustom-unitstheme setting.The solution involved ensuring the padding controls used the
useCustomUnithook, which gracefully handles consolidating the theme setting for custom units.Resolves #27829
How has this been tested?
Locally in Gutenberg.
npm run devadd_theme_support( 'custom-units' );from the themefunctions.phpadd_theme_support( 'custom-units' );from the themefunctions.phpChecklist: