Try: Cover position fix round 2 #28653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Type] Bug
|
Size Change: +67 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
sirreal
added
the
Backport to WP 6.7 Beta/RC
sirreal
approved these changes
Feb 3, 2021
|
Cherry-picked to |
ockham
pushed a commit
that referenced
this pull request
Feb 3, 2021
|
Also cherry-picked to |
|
Does this fix #28640? Can we close that issue? |
|
Yep, thank you noisy socks! |
noisysocks
pushed a commit
that referenced
this pull request
Feb 7, 2021
noisysocks
pushed a commit
that referenced
this pull request
Feb 8, 2021
noisysocks
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arguably better alternative to #28650, but please see that PR as well for a larger explainer on what the fundamental issue is.
Go there now, then come back and read the followup below. I'll wait.
...
Okay so the matrix aligner in the Cover block collapses every child block to its minimum dimensions so that it can align them to the corners. Which is problematic for responsive embeds, because they can collapse to 0x0.
This PR fixes that by assigning a minimum width/height to embeds:
But this opens questions:
initialwidth and heights when aligned?This PR works as a baseline, but I'm not sure what the best next step. Feel free to commandeer this PR.