-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pattern Directory API: Add a keyword
filter parameter
#28794
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryelle
added
the
[Feature] Pattern Directory
The Pattern Directory, a place to find patterns
label
Feb 5, 2021
Size Change: 0 B Total Size: 1.37 MB ℹ️ View Unchanged
|
TimothyBJacobs
approved these changes
Feb 5, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
iandunn
approved these changes
Feb 5, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We need to be able to fetch the core patterns from wordpress.org/patterns. These are identified by a
core
keyword (taxonomy), which already exists as a filter in the wp.org API. This PR adds a query parameter to expose this field for API requests.See #26578, which introduced the Pattern Directory API.
How has this been tested?
Added a unit test for the 'keyword' filter. This fetches some patterns from wp.org that have this keyword.
You can also request the patterns by keyword using the API:
GET /wp-json/__experimental/pattern-directory/patterns?keyword=11
11 is the ID for the
core
keyword. You should get back 10 patterns, all matching the patterns that are bundled in core.Checklist: