Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RNMobile] Ignore column width attribute when empty #29015

Merged
merged 3 commits into from
Feb 16, 2021
Merged

[RNMobile] Ignore column width attribute when empty #29015

merged 3 commits into from
Feb 16, 2021

Commits on Feb 16, 2021

  1. Ignore empty width attribute in columns 

    The editor was crashing when attempting to render a column block which contained an empty width attribute (i.e `<!-- wp:column {"width":""} -->`.
The exception occurred when accessing a property of an undefined object, so adding a default object (`|| {}`) fixes this by allowing the property to be accessed.
    @guarani
    guarani committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    10eba54 View commit details
    Browse the repository at this point in the history

  2. Update react-native-editor changelog

    @guarani
    guarani committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    cde7c18 View commit details
    Browse the repository at this point in the history

  3. Add missing dependency to useSelect in columns block

    @fluiddot
    fluiddot committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    10a0f16 View commit details
    Browse the repository at this point in the history