Fix shortcode not showing in the widgets screen #29282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin940726
added
[Type] Bug
|
Size Change: 0 B Total Size: 1.38 MB ℹ️ View Unchanged
|
kevin940726
requested review from
ajitbohra,
nerrad,
ntwb,
spacedmonkey and
TimothyBJacobs
as code owners
|
I think it was an explicit decision to avoid supporting shortcodes in these new screens. Can't we remove the block in these screens instead? |
|
I thought that I've read similar discussions somewhere, but couldn't remember where 🤔. |
|
I think @azaozz might remember this but yeah it's an oldish which we'd have a hard time finding :) |
|
@youknowriad I don't remember either taking such a decision. People use shortcodes to edit their sidebars so removing the block would make this new screen less functional than the old one. Also, what would be the advantage of not supporting such a block, as long as we edit the same old "sidebars"? |
|
This decision was made a long time ago :) and the reasoning is:
=> Don't support deprecated APIs in new things like FSE or widget screen. |
kevin940726
changed the title
draganescu
approved these changes
Mar 3, 2021
There was a problem hiding this comment.
Shortcodes are a functional element of the widget admin screen that we're trying to update here, so we should aim for feature partiy with the old screen. Fixing a bug with displaying them is therefore a good step in this direction.
On @youknowriad 's concern of trying to not bring along deprecated features into new things, it is a good perspective but it does not apply to this work here or to the navigation block editor as these editors aim to update old functionality, they're not new per se - as, say, the site editor is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #27793.
Add
do_shortcode()to the widgets screen.Also fixed flaky widgets e2e tests, as it turns out it's no longer expected to move focus to the newly added blocks.
How has this been tested?
Added e2e test, or:
[video src="http://commondatastorage.googleapis.com/gtv-videos-bucket/sample/BigBuckBunny.mp4"]Types of changes
Bug fix
Checklist: