Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a layout config to the group and theme.json and make alignments declarative #29335
Add a layout config to the group and theme.json and make alignments declarative #29335
Changes from all commits
732726b
8efe710
69945a7
6ede44f
192f069
21da8d4
67f481c
8fdebe1
2e59ef1
e266b7c
8565497
f546bb5
427c603
e34a2e1
8957d68
8ec5cc6
8d05994
f4caae0
4499d1b
a8000c7
a457f79
f15a746
01e434d
93f5e84
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@youknowriad Is there currently any API in PHP that we can use to combine all these styles at the start or end of the content?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can potentially use
wp_enqueue_style
but I believe we do inline style tags already (lazy loading of styles), so it's not the only place we do that.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mcsf same question as the other PR. Do we need to support this by default in the "block supports API"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(For reference, Riad is talking about the Duotone PR.)
I've been looking at this a bit, and I'm not sure. It's a departure from the explicit /
get_block_wrapper_attributes
. That's not necessarily bad, and this may be a necessary step, but it's worth discussing on its own. /cc @ajlende