Embed: fix select on focus #29431
Merged
Embed: fix select on focus #29431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -81 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
|
I tried to write an e2e test, but I can't emulate clicking in an iframe that is loading another web page. |
|
Thanks for looking at this! I'm still unable to re-focus the Embed block, though:
|
|
@mcsf What browser are you using? It seems to work fine for me.
|
|
I think #29892 is affecting testing here too. |
ellatrix
force-pushed
the
fix/embed-select-on-focus
branch
from
59fb2ff
to
748be3e
Compare
|
@mcsf I rebased the PR. Does it work correctly now? |
diegohaz
reviewed
Mar 18, 2021
There was a problem hiding this comment.
I tested it on Chrome and Safari and it's working.
Two things though (not necessarily blockers):
- I can't see the blue border when selecting the block with the mouse. And, because of that, I guess, I can't remove the block by pressing delete.
- I'm not sure if we have some kind of polyfill or something, but the
FocusEventconstructor doesn't work on IE11. It's better if we can just useactiveElement.focus().
Comment on lines
61
to
69
| // The focus event should *not* bubble: | ||
| // https://w3c.github.io/uievents/#event-type-focus | ||
| activeElement.dispatchEvent( new FocusEvent( 'focus' ) ); | ||
|
|
||
| // The focusin event *should* bubble: | ||
| // https://w3c.github.io/uievents/#event-type-focusin | ||
| activeElement.dispatchEvent( | ||
| new FocusEvent( 'focusin', { bubbles: true } ) | ||
| ); |
There was a problem hiding this comment.
Can't we just do this?
Suggested change
| // The focus event should *not* bubble: | |
| // https://w3c.github.io/uievents/#event-type-focus | |
| activeElement.dispatchEvent( new FocusEvent( 'focus' ) ); | |
| // The focusin event *should* bubble: | |
| // https://w3c.github.io/uievents/#event-type-focusin | |
| activeElement.dispatchEvent( | |
| new FocusEvent( 'focusin', { bubbles: true } ) | |
| ); | |
| activeElement.focus(); |
There was a problem hiding this comment.
This was first introduced in 5730. I didn't think it would work, but it does. The right window seems to stay focussed and I can keyboard navigate as you would expect.
ellatrix
force-pushed
the
fix/embed-select-on-focus
branch
from
748be3e
to
5f11360
Compare
ellatrix
commented
Mar 18, 2021
| iframe.dispatchEvent( focusEvent ); | ||
|
|
||
| if ( onFocus ) { | ||
| onFocus( focusEvent ); |
There was a problem hiding this comment.
We no longer need this since React will fire the right handlers when the element receives focus.
There was a problem hiding this comment.
Note that React will even call the right handlers with new FocusEvent. I'm not sure why this was ever added, but it was assumed React wouldn't pick it up.
|
Once this is approved and merged, I'll rebase #26753 to make this API better and reduce duplication. |
|
Ok, merging since the intention of this PR is fulfilled. I'll have a look into why Backspace is not removing the embed separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #29374. We switched to using the
focusinevent type instead offocusfor detecting block selection.How has this been tested?
Screenshots
Types of changes
Checklist: