Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parser: Hide the core namespace in serialised data #2950

Merged
merged 7 commits into from
Oct 12, 2017
Merged

Parser: Hide the core namespace in serialised data #2950

merged 7 commits into from
Oct 12, 2017

Commits on Oct 11, 2017

  1. First pass at hiding the core namespace in serialised data

    @pento
    pento committed Oct 11, 2017
    Configuration menu
    Copy the full SHA
    374605a View commit details
    Browse the repository at this point in the history

  2. Shuffle the parser changes around a little bit.

    @pento
    pento committed Oct 11, 2017
    Configuration menu
    Copy the full SHA
    b925d43 View commit details
    Browse the repository at this point in the history

  3. Add an error message for registering a block with uppercase character… 

    …s in the name.

This was never allowed, but now has an explicit error message for it.
    @pento
    pento committed Oct 11, 2017
    Configuration menu
    Copy the full SHA
    33c7e5d View commit details
    Browse the repository at this point in the history

  4. Add a serialiser test to ensure non-core namespaces are serialised co… 

    …rrectly.
    @pento
    pento committed Oct 11, 2017
    Configuration menu
    Copy the full SHA
    6e38298 View commit details
    Browse the repository at this point in the history

  5. Add a test for blocks with multiple /s in the name.

    @pento
    pento committed Oct 11, 2017
    Configuration menu
    Copy the full SHA
    f4b285d View commit details
    Browse the repository at this point in the history

  6. Shuffle the grammar around a bit more 

    Also, add a test that the parser parses non-namespaced block names.
    @pento
    pento committed Oct 11, 2017
    Configuration menu
    Copy the full SHA
    5ebaf95 View commit details
    Browse the repository at this point in the history

  7. Tweak the code in getCommentDelimitedContent() a little.

    @pento
    pento committed Oct 11, 2017
    Configuration menu
    Copy the full SHA
    0183c18 View commit details
    Browse the repository at this point in the history