Workflows: Add PHP Problem Matchers. #29638
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ockham
added
the
[Type] Automated Testing
|
Size Change: +1.67 kB (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
ockham
force-pushed
the
add/php-problem-matchers
branch
3 times, most recently
from
34f2438 to
8355f2d
Compare
ockham
force-pushed
the
add/php-problem-matchers
branch
from
3b6708e to
85b4c02
Compare
|
I think this was resolved by #46510. @anton-vlasenko can you confirm? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add problem matchers for phpunit, and PHPCS.
The phpunit config file is copied from https://github.com/shivammathur/setup-php, which is MIT licensed.
The PHPCS config file is copied over from https://github.com/chekalsky/phpcs-action, which is MIT licensed.
We'll probably need to add a proper copyright/licences notices.
This will cause GitHub to annotate the lines that cause phpunit and PHPCS lint errors in the diff.
TODO
How has this been tested?
TBD
Screenshots
Types of changes
Tooling