Debug e2e-tests in vscode #29788
Merged
Debug e2e-tests in vscode #29788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vcanales
added
[Package] E2E Test Utils
vcanales
added
[Type] Enhancement
|
Size Change: 0 B Total Size: 1.4 MB ℹ️ View Unchanged
|
|
This is cool, I tried this to debug a PR but for some reason it always triggered the whole suite even if I added a breakpoint to a particular test. How can we make sure that it triggers just the opened file or the files where there are breakpoints or something like that? |
|
Just gave it a test and as @youknowriad mentions it does run all tests. Adding |
vcanales
force-pushed
the
debug-e2e-tests-in-vscode
branch
from
57e61ca
to
24d091a
Compare
vcanales
force-pushed
the
debug-e2e-tests-in-vscode
branch
from
46818bc
to
bb3e66e
Compare
I'm actually not sure why in my testing it was working as described.
On my end, I solved it by appending I think using As an aside, it was brought to my attention that it's probably a better idea to contribute this as Docs instead of adding the workflow to the repo, having in mind that there are many IDEs out there, and we wouldn't want to take care of configurations for all of them here — as popular as it may be, I don't think I've added some instructions to |
Those instructions are fantastic. Thank you for adding them. 👏🏻 I noticed that there is some overlap with: Maybe we should consolidate everything with the existing document that is also exposed at: We can still link from the README file to make it easier to discover |
|
I honestly don't mind having these committed in the repository since it will benefit most developpers that deal with the e2e tests and since we already had a config for php things. |
The developers that use VSCode, write e2e tests and need to debug issues. It's rather a small subset of contributors, but I agree that it's helpful when you check all marks. It's a single file so I don't mind keeping it. It's just that https://github.com/WordPress/wordpress-develop doesn't have any files or code that is specific to IDEs to avoid discussion which of them should be supported. |
vcanales
force-pushed
the
debug-e2e-tests-in-vscode
branch
from
bb3e66e
to
8110ca0
Compare
vcanales
force-pushed
the
debug-e2e-tests-in-vscode
branch
from
8110ca0
to
4b87b47
Compare
|
With the launch file renamed in #31622, I'll be merging this as just another sample usage. |
|
I just saw this commit, and 🤯 Thanks, @vcanales! I might be asking too much, but does anyone have a working snippet for debugging Gutenberg code in the browser? 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a vscode launch configuration that allows inspecting e2e tests within vscode instead of using Chrome DevTools.
Demo
clip.mov