Revert: Show empty paragraphs on fronted. #29809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Feature] Shortcodes
aristath
approved these changes
Mar 12, 2021
|
Thank you Ari. I'd appreciate thoughts from Kjell or Ben before we merge this one. Just in case there's a solution other than a revert that I'm not seeing. |
|
Size Change: -120 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
|
It is not only shortcodes that have been affected by this, extra p tags are sometimes added when blocks in full site editing themes are rendered on the front. Until those extra p tags have been solved, I think this revert is needed. |
|
I think @joyously made a good point:
I wasn't aware of this, but it is true in my testing. Reverting seems best for now. |
scruffian
approved these changes
Mar 12, 2021
|
Thanks all. I'll merge when the checks pass and we can look at this again in the future. |
jasmussen
force-pushed
the
revert/empty-paragraphs
branch
from
3dba434
to
23795e8
Compare
|
I can't get the e2e tests to pass here. Any insights? |
mkaz
force-pushed
the
revert/empty-paragraphs
branch
from
23795e8
to
237ec4a
Compare
|
@gwwar Fixed the tests, I rebased and merged for you 🎉 |
This was referenced Mar 15, 2021
youknowriad
added
the
Backport to WP Minor Release
noisysocks
pushed a commit
that referenced
this pull request
Apr 6, 2021
noisysocks
removed
the
Backport to WP Minor Release
noisysocks
pushed a commit
that referenced
this pull request
Apr 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a followup to feedback in #27995 (comment) and https://core.trac.wordpress.org/ticket/52764.
In 27995 we merged a change where an empty paragraph written in the editor, would correspond to en empty paragraph on the frontend. This fixed #10051.
However shortcodes when they get parsed commonly generate lots of empty paragraphs (
<p></p>), which causes layout issues when those get inflated.This PR reverts the change.
Editor/frontend before:
Editor/frontend after:
How has this been tested?
Insert text, then a slew of linebreaks, then text again, and compare editor with frontend.
Observe that before, editor and frontend would match perfectly. Observe that after this PR, the paragraphs on the frontend collapse to zero height.
Types of changes
It's unfortunate that we might not be able to get accurate behavior here. But it is potentially something that could be revisited in the future.
Let me know your thoughts!
Checklist: