Navigation Block: Fix Anchor Support #30043
Closed
+13
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +5 B (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
|
Should we fix this by adding the id attribute with |
|
@Soean good call on the adding the id attribute to As for adding the anchor attribute, the attribute was not coming through to the PHP side in |
When we use a dynamic block we lose a lot of built-in functionality, since we're deferring rendering to the PHP callback. For example, even basic things like the block's classname needs to be added manually. This is normally called in: gutenberg/packages/blocks/src/api/serializer.js Lines 39 to 50 in a59d42d |
gwwar
approved these changes
Apr 1, 2021
There was a problem hiding this comment.
@georgeh This tests well for me. We could maybe get a +1 from folks to see if there's a better way. I suspect we do need to manually add this for a dynamic block.
cc @talldan @tellthemachines @noisysocks if you happen to know offhand.
| Value still exists after a save/load | Serialized to frontend |
|---|---|
 |
 |
georgeh
force-pushed
the
fix/navigation-anchor
branch
from
20a0bef to
50d14f1
Compare
I've not been involved in it but can recall PRs for server side supports properties. This folder looks like what's been tackled so far: |
|
Found this older PR as well - https://github.com/WordPress/gutenberg/pull/24699/files. |
|
#24699 appears to solve for the general case, closing this in favor of that PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #29401
Adds support for the anchor element in the Navigation block. It was not rendering and was being lost on save due to it being a dynamic block. Adding the
anchorattribute explicitly fixed the saving issue, and adding it to the render callback fixed the markup.Description
How has this been tested?
Tested with and without an anchor element to ensure that the
idattribute is only set if there is one.Screenshots
Types of changes
Checklist: