Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Responsive Navigation #30047

Merged
merged 35 commits into from
May 12, 2021
Merged

Responsive Navigation #30047

merged 35 commits into from
May 12, 2021

Commits on May 3, 2021

  1. Implement responsive navigation menu 

    Gives the user the option to have the Navigation Block show up behind a
button on smaller screens.
This menu can be controlled with the keyboard.
    @vcanales
    vcanales committed May 3, 2021
    Configuration menu
    Copy the full SHA
    6d9f03b View commit details
    Browse the repository at this point in the history

  2. only hide closing button if menu is closed 

    Make sure that the button does not disappear when resizing the viewport
while the menu is open.
    @vcanales
    vcanales committed May 3, 2021
    Configuration menu
    Copy the full SHA
    885fcb5 View commit details
    Browse the repository at this point in the history

  3. make sure frontend.js is only being loaded once

    @vcanales
    vcanales committed May 3, 2021
    Configuration menu
    Copy the full SHA
    fa50591 View commit details
    Browse the repository at this point in the history

  4. Fix issues with open modal.

    @jasmussen @vcanales
    jasmussen authored and vcanales committed May 3, 2021
    Configuration menu
    Copy the full SHA
    f433a9a View commit details
    Browse the repository at this point in the history

  5. make sure scripts are only loaded once

    @vcanales
    vcanales committed May 3, 2021
    Configuration menu
    Copy the full SHA
    7729c3f View commit details
    Browse the repository at this point in the history

  6. Add a focus z index so focus isn't cropped.

    @jasmussen @vcanales
    jasmussen authored and vcanales committed May 3, 2021
    Configuration menu
    Copy the full SHA
    ab29f51 View commit details
    Browse the repository at this point in the history

  7. Fix ariaHidden

    @jasmussen @vcanales
    jasmussen authored and vcanales committed May 3, 2021
    Configuration menu
    Copy the full SHA
    6ea6ed1 View commit details
    Browse the repository at this point in the history

  8. Fix color issue.

    @jasmussen @vcanales
    jasmussen authored and vcanales committed May 3, 2021
    Configuration menu
    Copy the full SHA
    f40546d View commit details
    Browse the repository at this point in the history

  9. Fix safari issue.

    @jasmussen @vcanales
    jasmussen authored and vcanales committed May 3, 2021
    Configuration menu
    Copy the full SHA
    0c2a4dc View commit details
    Browse the repository at this point in the history

  10. only enqueue frontend script if needed 

    Needed when:
- Responsive navigation is on.
- Script hasn't been loaded already.

Also, only attempt to load the file if it exists. This only really guards against
potential build problems, as in theory it should never be absent.
    @vcanales
    vcanales committed May 3, 2021
    Configuration menu
    Copy the full SHA
    3df9544 View commit details
    Browse the repository at this point in the history

  11. use isResponsive instead of responsiveNavigation

    @vcanales
    vcanales committed May 3, 2021
    Configuration menu
    Copy the full SHA
    a7dac30 View commit details
    Browse the repository at this point in the history

  12. Fix modal id

    @vcanales
    vcanales committed May 3, 2021
    Configuration menu
    Copy the full SHA
    2eb3b68 View commit details
    Browse the repository at this point in the history

  13. Update package-lock, move deps to correct place

    @vcanales
    vcanales committed May 3, 2021
    Configuration menu
    Copy the full SHA
    82f85e1 View commit details
    Browse the repository at this point in the history

  14. Fix aria-hidden label in the editor

    @vcanales
    vcanales committed May 3, 2021
    Configuration menu
    Copy the full SHA
    f80f54a View commit details
    Browse the repository at this point in the history

  15. Set responsiveness off by default

    @vcanales
    vcanales committed May 3, 2021
    Configuration menu
    Copy the full SHA
    d22e43d View commit details
    Browse the repository at this point in the history

  16. Add missing aria attributes

    @vcanales
    vcanales committed May 3, 2021
    Configuration menu
    Copy the full SHA
    3808578 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2021

  1. update e2e fixture

    @vcanales
    vcanales committed May 4, 2021
    Configuration menu
    Copy the full SHA
    637bb09 View commit details
    Browse the repository at this point in the history

  2. remove unnecessary context declaration

    @vcanales
    vcanales committed May 4, 2021
    Configuration menu
    Copy the full SHA
    2cd59a7 View commit details
    Browse the repository at this point in the history

  3. remove file existence check

    @vcanales
    vcanales committed May 4, 2021
    Configuration menu
    Copy the full SHA
    ccd361f View commit details
    Browse the repository at this point in the history

Commits on May 7, 2021

  1. Tests responsiveness on preview page 

    Also add function to turn responsiveness on.
    @vcanales
    vcanales committed May 7, 2021
    Configuration menu
    Copy the full SHA
    dadce1c View commit details
    Browse the repository at this point in the history

  2. Refactor server side render of nav menu 

    Early return if responsiveness is off.
    @vcanales
    vcanales committed May 7, 2021
    Configuration menu
    Copy the full SHA
    a59dff6 View commit details
    Browse the repository at this point in the history

  3. Make sure toggle button labels are translatable

    @vcanales
    vcanales committed May 7, 2021
    Configuration menu
    Copy the full SHA
    986c192 View commit details
    Browse the repository at this point in the history

  4. Only render open button if menu is closed

    @vcanales
    vcanales committed May 7, 2021
    Configuration menu
    Copy the full SHA
    bc9bb9c View commit details
    Browse the repository at this point in the history

Commits on May 10, 2021

  1. Remove duplicate CSS from rebase.

    @jasmussen @vcanales
    jasmussen authored and vcanales committed May 10, 2021
    Configuration menu
    Copy the full SHA
    0d12f7c View commit details
    Browse the repository at this point in the history

  2. Fix focus cropping issue.

    @jasmussen @vcanales
    jasmussen authored and vcanales committed May 10, 2021
    Configuration menu
    Copy the full SHA
    a12aeea View commit details
    Browse the repository at this point in the history

  3. Simplify overlay style.

    @jasmussen @vcanales
    jasmussen authored and vcanales committed May 10, 2021
    Configuration menu
    Copy the full SHA
    7065648 View commit details
    Browse the repository at this point in the history

  4. Fix for page list.

    @jasmussen @vcanales
    jasmussen authored and vcanales committed May 10, 2021
    Configuration menu
    Copy the full SHA
    5da3bfd View commit details
    Browse the repository at this point in the history

  5. Remove a few todos.

    @jasmussen @vcanales
    jasmussen authored and vcanales committed May 10, 2021
    Configuration menu
    Copy the full SHA
    1b9885f View commit details
    Browse the repository at this point in the history

  6. Fix overlay on desktop breakpoints style, and focus styles.

    @jasmussen @vcanales
    jasmussen authored and vcanales committed May 10, 2021
    Configuration menu
    Copy the full SHA
    dd97947 View commit details
    Browse the repository at this point in the history

  7. Small transparency fix.

    @jasmussen
    jasmussen committed May 10, 2021
    Configuration menu
    Copy the full SHA
    dc9d315 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2021

  1. keep parameter order consistency

    @vcanales
    vcanales committed May 11, 2021
    Configuration menu
    Copy the full SHA
    516e7a6 View commit details
    Browse the repository at this point in the history

  2. Address feedback

    @vcanales
    vcanales committed May 11, 2021
    Configuration menu
    Copy the full SHA
    10adcaa View commit details
    Browse the repository at this point in the history

  3. Update packages/block-library/src/navigation/frontend.js 

    Co-authored-by: Miguel Fonseca <miguelcsf@gmail.com>
    @vcanales @mcsf
    vcanales and mcsf committed May 11, 2021
    Configuration menu
    Copy the full SHA
    4b0ecda View commit details
    Browse the repository at this point in the history

  4. remove no-longer needed css rules

    @vcanales
    vcanales committed May 11, 2021
    Configuration menu
    Copy the full SHA
    b2990cd View commit details
    Browse the repository at this point in the history

  5. edit redundant callback definition

    @vcanales
    vcanales committed May 11, 2021
    Configuration menu
    Copy the full SHA
    2769bd2 View commit details
    Browse the repository at this point in the history