-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore the inner div of the group block in the editor for classic themes #30453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
Backwards Compatibility
Issues or PRs that impact backwards compatability
[Feature] Themes
Questions or issues with incorporating or styling blocks in a theme.
labels
Apr 1, 2021
Size Change: +15 B (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
fullofcaffeine
approved these changes
Apr 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Cherry-picked to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Backwards Compatibility
Issues or PRs that impact backwards compatability
[Feature] Themes
Questions or issues with incorporating or styling blocks in a theme.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #30443
In Gutenberg 10.3 we introduced the layout config #29335 and removed the useless inner div for group blocks. Some themes used to rely on that div for their styles so we decided to keep it in the frontend. The issue is that the breakage for these themes in the editor might be important. This PR restores the div in the editor as well for these themes.