Show the label for archives block dropdown #30527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JustinyAhin
added
[Block] Archives
youknowriad
reviewed
Apr 6, 2021
| @@ -60,7 +60,7 @@ function render_block_core_archives( $attributes ) { | |||
|
|
|||
| $label = esc_html( $label ); | |||
|
|
|||
| $block_content = '<label class="screen-reader-text" for="' . $dropdown_id . '">' . $title . '</label> | |||
There was a problem hiding this comment.
Do we know why this has been added in the first place?
Also, if we decide to remove it, we should remove it from the editor as well. Also, this is the only place where this class is used for Core blocks which means we need to remove the styles defined in common.scss for it as well.
There was a problem hiding this comment.
Do we know why this has been added in the first place?
When looking at the PR in which this block has been introduced (#7949) I can't find a context about why this class was added in the first place.
I assume it's because they want to hide it (?) but still making it available in the screen reader tree.
There was a problem hiding this comment.
The original PR matched the widget I believe
There was a problem hiding this comment.
Also, if we decide to remove it, we should remove it from the editor as well.
It isn't what happens when I remove the class in /block-library/src/archives/index.php? It is removed in the editor and in the frontend.
There was a problem hiding this comment.
The original PR matched the widget I believe
So it may be to avoid duplicate with the widget title 🤔
There was a problem hiding this comment.
Also, this is the only place where this class is used for Core blocks which means we need to remove the styles defined in
common.scssfor it as well.
It is also used for the Core Search block
There was a problem hiding this comment.
The original PR matched the widget I believe
It's been a long time, but I assume it was following prior art. I don't know how relevant that label still is.
There was a problem hiding this comment.
@joedolson , do you think there's an accessibility context for this screen-reader-text class? Thanks :)
There was a problem hiding this comment.
I also don't recall. It was one of the first PRs I contributed, but I mostly took over from a contributor that wasn't able to finish it.
youknowriad
reviewed
Apr 6, 2021
|
Size Change: +54 B (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
|
What if, the label was visible by default, but there was an option for hiding it? |
|
I personally don't mind the PR as is here, but it does impact the output a bit, too not sure how we can "judge" whether this impact on themes is acceptable or not.. |
carolinan
approved these changes
May 23, 2021
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up #11219 that has been closed.
This PR shows the label markup for the archives block when the dropdown option is selected.
Fixes #11002.
How has this been tested?
Screenshots
Editor before
Frontend before
Editor after
Frontend after
Types of changes
This is mostly a CSS change.
I've removed the
screen-reader-textclass from the archives block label markup (gutenberg/packages/block-library/src/archives/index.php
Line 63 in 3882276
I also added a new CSS file to style the label on the frontend.
Checklist:
*.native.jsfiles for terms that need renaming or removal).