Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Media & Text: Add media width control #31002

Merged
merged 2 commits into from
May 12, 2021
Merged

Media & Text: Add media width control #31002

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0bcd21b
Media & Text: Add media width control
Mamaduka Apr 20, 2021
690b3f9
Removes RangeControls marks
Mamaduka Apr 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions packages/block-library/src/media-text/edit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import {
} from '@wordpress/block-editor';
import {
PanelBody,
RangeControl,
TextareaControl,
ToggleControl,
ToolbarButton,
Expand Down Expand Up @@ -49,6 +50,7 @@ const TEMPLATE = [
},
],
];

// this limits the resize to a safe zone to avoid making broken layouts
const WIDTH_CONSTRAINT_PERCENTAGE = 15;
const applyWidthConstraints = ( width ) =>
Expand Down Expand Up @@ -276,6 +278,15 @@ function MediaTextEdit( { attributes, isSelected, setAttributes } ) {
isResizable={ false }
/>
) }
{ mediaUrl && (
<RangeControl
label={ __( 'Media width' ) }
value={ temporaryMediaWidth || mediaWidth }
onChange={ commitWidthChange }
min={ WIDTH_CONSTRAINT_PERCENTAGE }
max={ 100 - WIDTH_CONSTRAINT_PERCENTAGE }
/>
) }
</PanelBody>
);

Expand Down