Apply a StyleProvider around fills that can be used inside the iframe #31073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Bug
|
What do you think @ellatrix @sarayourfriend I'm personally hesitant but I feel this is better than having to rely on a custom emotion for the components. |
|
Interesting challenges to solve 😄 I think there is also a Fill for the dropdown menu items in the block toolbar to cover if you decide to go this path. |
|
Size Change: +40 B (0%) Total Size: 1.47 MB
ℹ️ View Unchanged
|
|
I'd rather this than relying on a custom wrapper. If for some reason this becomes too much we can always revisit the custom wrapper just like we said we'd revisit vanilla emotion the other way around. iframe support should only get better in vanilla emotion though 🤷♀️ |
packages/block-editor/README.md
Outdated
| _Related_ | ||
|
|
||
| - <https://github.com/WordPress/gutenberg/blob/HEAD/packages/block-editor/src/components/block-settings-menu-controls/README.md> | ||
| Undocumented declaration. |
There was a problem hiding this comment.
Whoops, why did this happen?
Comment on lines
73
to
81
| function BlockSettingsMenuControls( { ...props } ) { | ||
| return ( | ||
| <StyleProvider iframeDocument={ document }> | ||
| <Fill { ...props } /> | ||
| </StyleProvider> | ||
| ); | ||
| } | ||
|
|
||
| BlockSettingsMenuControls.Slot = BlockSettingsMenuControlsSlot; |
There was a problem hiding this comment.
You're missing the default export now I believe.
| @@ -13,7 +16,11 @@ const { Fill, Slot } = createSlotFill( name ); | |||
|
|
|||
| function InspectorAdvancedControls( { children } ) { | |||
| const { isSelected } = useBlockEditContext(); | |||
| return isSelected ? <Fill>{ children }</Fill> : null; | |||
| return isSelected ? ( | |||
| <StyleProvider iframeDocument={ document }> | |||
There was a problem hiding this comment.
What if we changed iframeDocument to just be document? At this point it's not just for iframes 😞
There was a problem hiding this comment.
yes, it makes sense :)
|
Sounds good to me. It would be nice if it somehow automatically looked at the |
youknowriad
force-pushed
the
add/parent-style-provider-to-fills
branch
from
ca0af65 to
06790fd
Compare
youknowriad
added a commit
that referenced
this pull request
Apr 23, 2021
|
Nice, I hope we didn't miss any fills. What is rendered inside the iframe? I was thinking about all plugins that integrate with the sidebar or the publish sidebar. |
|
these are ok, the issue is when the elements are rendered inside the iframe for slots that appear outside the iframe. |
|
In theory, you could render all plugins inside |
This was referenced May 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #31070
#31010 fixed CSS-in-JS inside the iframe but it broken the styles applied to components rendered inside portals inside the iframe. These portals actually render the elements outside the iframe.
This means we need to wrap these portals with a style provider referring to the parent document.