components: Promote VStack and HStack #31300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarayourfriend
added
[Package] Components
sarayourfriend
requested review from
ajitbohra and
chrisvanpatten
as code owners
|
Size Change: +858 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
gziolo
reviewed
Apr 29, 2021
sarayourfriend
force-pushed
the
add/promote-flex
branch
from
ec64274 to
0edc7d0
Compare
gziolo
force-pushed
the
add/promote-stack-components
branch
from
abd3b35 to
233cbb7
Compare
gziolo
reviewed
Apr 30, 2021
| import { | ||
| __experimentalHStack as HStack, | ||
| __experimentalText as Text, | ||
| __experimentalView as View, |
There was a problem hiding this comment.
I assume that View is going to be moved quite soon.
gziolo
reviewed
Apr 30, 2021
| import { HStack, Spacer, Text, View } from '@wordpress/components/ui'; | ||
| import { | ||
| __experimentalHStack as HStack, | ||
| __experimentalSpacer as Spacer, |
There was a problem hiding this comment.
There is no Spacer in @wordpress/components yet. Should we replace it with something else in this README file?
gziolo
reviewed
Apr 30, 2021
gziolo
reviewed
Apr 30, 2021
|
There is no story for A story for
|
gziolo
approved these changes
Apr 30, 2021
There was a problem hiding this comment.
@sarayourfriend, I rebased this PR and applied all the necessary changes to make the story for HStack render properly in Storybook. I also applied a few changes to match with previously moved components.
The one remaining question is what do we do about all mentions of the Spacer component.
|
We can migrate Spacer as part of this PR? Or add it in a previous PR that this PR then is blocked by? |
|
I opened a Spacer PR here: #31509 We can merge it first and then incorporate it into the stories for HStack and VStack. |
There is no need to wait. I mostly raised it so we are aware that documentation contains |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Promote the HStack and VStack components to experimental exports from
@wordpress/components. These are brand new components.How has this been tested?
Storybook still works. There's nothing to test otherwise because they're new components.
Types of changes
New feature.
Checklist:
*.native.jsfiles for terms that need renaming or removal).