Update: Target global styles to the body element instead of :root #31302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
the
Global Styles
jorgefilipecosta
requested review from
ajitbohra,
chrisvanpatten,
oandregal and
spacedmonkey
as code owners
|
Size Change: -3 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
youknowriad
approved these changes
Apr 29, 2021
youknowriad
added
[Type] Enhancement
jorgefilipecosta
deleted the
update/target-global-styles-to-body-instead-of-root
branch
|
I'm looking at this in relation to issue #35840 and trying to understand the reason for moving from You mention...
Am I right in thinking that you are going to use the Would it be possible to keep custom properties in Thanks for your help. |
|
The arguments for the change in #27478 don't seem to be based on any real reason. |
|
Many existing solutions inside and outside the WordPress ecosystem use Also, as linked and proven in #35840, moving the rules from |
1 task
|
It looks like the consequences for CSS custom properties were not completely thought through. Particularly, if anyone has built a JavaScript app that interacts with the global properties, they most likely use
or an equivalent way to set these. Similarly this W3C page on how to interact with them in JS uses When all properties are by default set on |
|
Bumping this again as pull request #42084 which addressed the issue was marked as “not a priority”. I'd like to know why this isn't a priority, and how the development team came to this conclusion. |
|
This is still a problem, see #42084 and #35840. cc @jorgefilipecosta. |
The "development team" was essentially me. #42084 lost all traction from reviewers and testers, despite being open for months. The good news is that PRs can be cheaply reopened when issues resurface. 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #27478
Currently, the global styles target the :root selector. In a HTML element the :root selector maps to HTML element. It seems more correct to target body for the global styles use case. And will allow for things like margin and padding.
The body selector has lower specificity than :root so this change may have some impact.
How has this been tested?
I verified global colors and typography settings still work as before.
I applied preset a global text color, and I changed that color using the palette editor and verified the text color of the editor live update for the new color value.