Fix Inserter Drag and Drop #31319
Merged
Fix Inserter Drag and Drop #31319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Bug
|
A couple things that might be good to follow-up with:
|
|
Size Change: +6 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
|
@youknowriad I made an e2e test for drag and drop of a block, it should be possible with the inserter too, but it's not straightforward to do. Hopefully the approach can be copied. |
|
I've filed #31356 to request an e2e test for the inserter's drag-and-drop feature. |
|
Yes, that's the one :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent refactor to block drag and drop caused a regression on the inserter drag and drop because of the new transfer type prop. This PR fixes it.
Ideally, the "type" property in the data transfer object should be consolidated with this new prop.