Remove tools dropdown menu from medium viewport when text labels mode is active #31431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
General Interface
|
Size Change: -223 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
|
Here's before:
Here's after:
To an extent, both are not great because the labels-only feature feels like it hasn't received a lot of design thought in the initial implementation. However at least this feels simpler, without this weird merged dropdown. It seems like #31134 might enable us to remove those at a bigger breakpoint? But as is, I'd be okay with shipping this feature; even though it doesn't improve substantially upon the existing visuals, at least it removes some of the complexity. What do you think? |
|
that's my thinking, the current design is "broken" and we already remove these tools for the smaller breakpoint, so let's just do that for this breakpoint too until we come up with a good design for this. |
jasmussen
approved these changes
May 4, 2021
youknowriad
force-pushed
the
remove/textual-header-dropdown
branch
from
19f05a3 to
4551baf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When "Display button labels" mode is enabled, we had this weird dropdown menu composed of several tools mixed together. Design wise and behavior wise, this menu was very confusing and would require to be rethought.
On small viewports, that menu is removed entirely, so this PR is just matching the "small" and "medium" viewports behavior which allows us to get rid of that dropdown menu.
This is the menu we're talking about.