Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add color and typography support for the file block. #31465

Conversation

juanfra
Copy link
Member

@juanfra juanfra commented May 4, 2021

Description

How has this been tested?

  • Added the file block, changed colors and typography. Saved and viewed in the front end.

Screenshots

Types of changes

  • Modifying the block.json for the file block, adding support for color and typography.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@juanfra juanfra requested a review from ajitbohra as a code owner May 4, 2021 14:14
@skorasaurus skorasaurus added the [Block] File Affects the File Block label May 15, 2021
@Mamaduka
Copy link
Member

Hello, @juanfra

I think it might be better to limit this PR only to background/color support.

There're some discussions about typography support for blocks. We probably add support for those separately once the final decision is made.

Thanks

@juanfra
Copy link
Member Author

juanfra commented May 4, 2023

stale

@juanfra juanfra closed this May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] File Affects the File Block
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File Block: Add background/text color support
3 participants