Fix nav color regression #31495
Closed
Fix nav color regression #31495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
commented
May 5, 2021
| .wp-block-navigation-link__content { | ||
| // The addition of :not(.wp-block-button_link) is necessary to override generic link colors from global styles. | ||
| .wp-block-pages-list__item__link:not(.wp-block-button_link), | ||
| .wp-block-navigation-link__content:not(.wp-block-button_link) { |
There was a problem hiding this comment.
I could have added :not(.any-random-class) and it would have worked. That's why I'm not really a fan of using :not in the first place. It's essentially an "allow-list" of blocks to ignore.
|
Size Change: +48 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
|
I'm looking at #31497 as an alternate fix. Happy to hear feedback. |
|
Closing this one in favor of #31497. Thanks André! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes navigation block color regression from #30541.
Before:
After:
How has this been tested?
Insert a navigation block and add a background and foreground color. The text color of menu items should be correct.
Types of changes
This isn't a great change — it adds specificity to override specificity. But it may still be necessary.
Checklist:
*.native.jsfiles for terms that need renaming or removal).