Return consolidated global styles in REST Request #31762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
added
Global Styles
7 tasks
|
Size Change: 0 B Total Size: 1.31 MB ℹ️ View Unchanged
|
geriux
reviewed
May 12, 2021
|
Hey @nosolosw thanks for making these changes! Quick question, when I changed the default background color from {
"styles": {
"color": {
"background": "var:preset|color|red",
"text": "var(--wp--preset--color--dark-gray)"
}
}
}Is the value of the background correct |
Yeah, that's expected. That's because the user selected a "preset" color from the theme palette. The value of that can be found under |
Right, I guess I was expecting the value to be like:
Instead of
Thought it might be a parsing issue there. |
|
🤔 Now that I think of it: I believe we needed that format for the post editor because @jorgefilipecosta had found some issues using the CSS Custom Properties directly. I presume issues with KSES. However, we're switching away from variables in the post editor #31488 so I wonder if we can remove that format: a lot less logic, indirection, and code to maintain. It looks like in the site editor we wouldn't need to use it anyway. Jorge, do you have thoughts on this? |
|
Tested this in various scenarios (post editor, site editor, rest) and works as expected. |
oandregal
commented
May 13, 2021
| // needs the ability to create them. Hence, we pass it some data | ||
| // for this: base styles (core+theme) and the ID of the user CPT. | ||
|
|
||
| if ( defined( 'REST_REQUEST' ) && REST_REQUEST ) { |
There was a problem hiding this comment.
I don't like this now. See https://github.com/WordPress/gutenberg/pull/29969/files#r631772812
7 tasks
This was referenced May 18, 2021
36 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #29969
This PR covers a new use case for settings: REST Request. The API is going to be used by the mobile apps to get access to the data. Some data it needs is the consolidated global styles from core, theme, and user.
How to test
<your_site>/wp-json/__experimental/wp-block-editor/v1/settingsand verify that you have access to all the settings (including the ones at__experimentalStyles).Note: a quick way to test the endpoint is to add a return true; within get_items_permissions_check in the lib/class-wp-rest-block-editor-settings-controller.php file.