Spacing support: Add server-side support for margins #31808
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the margin block support on the server-side allowing dynamic blocks to use it. The existing
padding.php
block support file is renamed tospacing
to reflect the existing block support's structure.How has this been tested?
Testing instructions
Your theme will need to opt into padding support. You can do this by updating your
theme.json
to enable padding under the spacing control, in either your default settings or the block context for button:I used the Site Title block for testing, as it supports both margin and padding on trunk.
Test Instructions
You can verify the bug first on trunk by:
Test the PR:
**Note that if added as a top-level block, left and right margins may be overridden by the
!important
styles from the layout block support. You should still be able to see the styles added.Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist:
*.native.js
files for terms that need renaming or removal).