[WIP] Columns: Add custom gutters via margin support and dynamic columns block #31987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This converts the columns block to a dynamic block. This is so that CSS variables can be used for the margin support values. Which in turn allows CSS to utilise these in responsive styles.
aaronrobertshaw
added
[Type] Enhancement
aaronrobertshaw
requested review from
spacedmonkey and
TimothyBJacobs
as code owners
|
Size Change: +298 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
|
Closing this in favour of CSS Grid approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: #31973
Related: #24874 & #31816
Description
The responsive behaviour of the columns block and its use of media queries prevents default use of margins block support to control gutters.
This PR is a proof of concept to convert the columns block to be dynamic and inject CSS variables for the margin into the markup. CSS variables cannot be added into the inline styles saved in the block content, they will get stripped out by kses.
Next Steps
How has this been tested?
Manually
customMarginsupport viaexperimental-theme.jsonsmallviewport, the flex-basis is updated to be50% - margin/2to achieve 2 column layoutTest block code
Screenshots
Types of changes
New feature
Checklist:
*.native.jsfiles for terms that need renaming or removal).