Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Reusable block save button, snackbar on save and Welcome Guide #32464

Closed
wants to merge 22 commits into from
Closed

Add Reusable block save button, snackbar on save and Welcome Guide #32464

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
8bc50d4
Add Reusable block save button, snackbar on save and Welcome Guide
thisissandip Jun 4, 2021
fd391bd
Update the way to check dirty records and Fix l10n
thisissandip Jun 11, 2021
afe9922
Remove External Link and Update Finish Button Text in Welcome Gudie
thisissandip Jun 11, 2021
424fbc9
Move Save Button to it's own group
thisissandip Jun 15, 2021
a4f9b21
move hasEdits to top useSelect
thisissandip Jun 15, 2021
297e62e
Fix ESLint Errors
thisissandip Jun 15, 2021
ea6ef3a
rebase
thisissandip Jun 29, 2021
38fbea7
Add welcome guide image
thisissandip Jul 7, 2021
355595a
welcome guide updates and make save button to 32px in height
thisissandip Jul 12, 2021
1046bc4
Save button box inset
thisissandip Jul 14, 2021
35e713b
fix typos and add css comments
thisissandip Jul 17, 2021
a0ab538
add dot to parent selector for reusable block
thisissandip Jul 28, 2021
da40570
Add dot to block parent seletor and reusable block toolbar
thisissandip Aug 4, 2021
1952b92
add two separate components for unsaved changes indicator
thisissandip Aug 12, 2021
cd7bca8
undo block switcher changes
thisissandip Aug 12, 2021
0df63a4
hide save btn when there are no changes
thisissandip Aug 30, 2021
2a213ee
Merge pull request #1 from thisissandip/add/dot-to-parent-selector
thisissandip Aug 31, 2021
74fcdd6
update label and adjust margin
thisissandip Sep 8, 2021
f038b11
use grid-unit-10
thisissandip Sep 8, 2021
6e5b545
adjust unsaved changes indicator margin
thisissandip Sep 9, 2021
bf3eaf9
increase parent selector focus indicator width
thisissandip Sep 14, 2021
740a109
gets rid of visual jump
kellychoffman Nov 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/block-library/src/block/edit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ export default function ReusableBlockEdit( { attributes: { ref }, clientId } ) {
isPrimary
className="block-library-block__reusable-block-save-button"
onClick={ saveEditedRecords }
label={ __( 'Save reusable block' ) }
label={ __( 'Save globally' ) }
showTooltip
>
{ __( 'Save' ) }
Expand Down
2 changes: 1 addition & 1 deletion packages/block-library/src/block/editor.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
// Styles for save button
.components-toolbar-group {
.block-library-block__reusable-block-save-button {
margin: 7px;
margin: 8px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use $grid-unit-10 instead of 8px if you like.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, Yes! Thank you! 😄

height: $grid-unit-40;

// override the default box inset properties to match height and width of the save button
Expand Down