Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block Support: Add height block support feature #32499

Closed
wants to merge 8 commits into from
Closed

Block Support: Add height block support feature #32499

wants to merge 8 commits into from

Commits on Feb 18, 2022

  1. Add height dimensions block support 

    After the release of 5.9, the theme.json php class related changes will be added via a separate isolated commit.
    @aaronrobertshaw
    aaronrobertshaw committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    e294e91 View commit details
    Browse the repository at this point in the history

  2. Initial updates to extend theme.json classes post 5.9

    @aaronrobertshaw
    aaronrobertshaw committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    74d8124 View commit details
    Browse the repository at this point in the history

  3. New settings (works in WordPress 5.9) 

    Rename wp_get_global_settings to gutenberg_get_global_settings.

In WordPress 5.9 the wp_* function is already defined,
so we can't override them. It's calling the existing
WP_Theme_JSON classes in WordPress core so it won't pick up
the plugin modification.

In the plugin, to make sure these changes work fine in 5.9
as well, we need to use the gutenberg_* function instead.
    @oandregal @aaronrobertshaw
    oandregal authored and aaronrobertshaw committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    a457e8e View commit details
    Browse the repository at this point in the history

  4. New styles (works in WordPress 5.9)

    @oandregal @aaronrobertshaw
    oandregal authored and aaronrobertshaw committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    8d0b11e View commit details
    Browse the repository at this point in the history

  5. Fix for WordPress 5.9: gutenberg_get_global_stylesheet should call th… 

    …e Gutenberg classes
    @oandregal @aaronrobertshaw
    oandregal authored and aaronrobertshaw committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    fbc677d View commit details
    Browse the repository at this point in the history

  6. Fix lint issues

    @oandregal @aaronrobertshaw
    oandregal authored and aaronrobertshaw committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    c4b286b View commit details
    Browse the repository at this point in the history

  7. Move functions to the compat/6.0 folder 

    While this PR does not do any behavioral change,
we still need to call the plugin clasess when the
minimum plugin version is 5.9 (at which point,
the compat/5.9 is removed).
    @oandregal @aaronrobertshaw
    oandregal authored and aaronrobertshaw committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    34f96ed View commit details
    Browse the repository at this point in the history

  8. Add get_theme_item to global styles controller

    @aaronrobertshaw
    aaronrobertshaw committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    0023551 View commit details
    Browse the repository at this point in the history