Use block supports API to check for Nav Block feature support #32597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
changed the title
|
Size Change: +34 B (0%) Total Size: 1.03 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A PoC PR which is part of #30007 (comment).
This aims to control the availability of two "features" of the Navigation block via the Block Supports API:
This works apart from the fact that the block PHP rendering function no longer has access to the (now removed) attributes via the block's context. We'd need to solve this issue.
How has this been tested?
core/navigationsblock.json.false:falseare no longer available.Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).