components: Allow for non-polymorphic components #32796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarayourfriend
force-pushed
the
add/non-polymorphic-components
branch
from
1a1ef99 to
19869e8
Compare
|
Size Change: 0 B Total Size: 1.04 MB ℹ️ View Unchanged
|
sarayourfriend
requested review from
ajitbohra and
chrisvanpatten
as code owners
sarayourfriend
force-pushed
the
add/non-polymorphic-components
branch
from
e7e4243 to
c8a0ecf
Compare
ciampo
approved these changes
Jun 22, 2021
| export type PolymorphicComponent< | ||
| T extends React.ElementType, | ||
| O, | ||
| IsPolymorphic extends boolean |
There was a problem hiding this comment.
Why doesn't IsPolymorphic here default to true, like it does in PolymorphicComponentProps ?
There was a problem hiding this comment.
Just because PolymorphicComponent is never used directly, so there's no reason to give it a default. It helps with compiler warnings when casting PolymorphicComponentProps to a PolymorphicComponent in case there's ever a mistake there.
There was a problem hiding this comment.
Got it, thank you for the explanation. Feel free to ignore this comment :)
sarayourfriend
force-pushed
the
add/non-polymorphic-components
branch
from
c8a0ecf to
e7b6ca4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Simplifies some type extraction and also adds non-polymorphism.
We should probably rename all this stuff to just like "WordPressComponent" or something like that.
How has this been tested?
Type checks pass! Also you should be able to use the
Dividerand not assign anasprop to it, TypeScript should error telling you that you cannot assign anything tonever.Types of changes
New feature
Checklist:
*.native.jsfiles for terms that need renaming or removal).