Block Library: Unify handling for block view scripts #32814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
[Type] Build Tooling
|
Size Change: -3.63 kB (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
gziolo
force-pushed
the
update/block-view-scripts-handling
branch
2 times, most recently
from
b566d9b
to
9eeafb4
Compare
gziolo
requested review from
ajitbohra,
nerrad,
ntwb,
spacedmonkey and
TimothyBJacobs
as code owners
gziolo
commented
Jun 21, 2021
|
@vcanales and @jasmussen, I would appreciate a sanity check from you for the Navigation block and in regards to all the changes applied to how this mechanism works now to account for the fact that the same PHP files power both the block in the Gutenberg plugin and in WordPress core. @pento, I would appreciate a sanity check for the File block. As part of this PR I also sorted out the issue you raised in the past about the potential name conflict between packages and blocks by using the following name patterns for entry points: [ 'blocks/' + blockName ]: scriptPath, |
jorgefilipecosta
approved these changes
Jun 21, 2021
|
This should be backported to core right? |
|
What about the e2e test failures here, are they unrelated? (the navigation one specifically) |
youknowriad
added
the
Backport to WP 6.7 Beta/RC
aristath
approved these changes
Jun 22, 2021
|
Thanks for looking at this. As we introduce core blocks that have a reliance on frontend scripts it's important to ensure the APIs created move in the right direction. |
I'm looking into it now. It feels like an issue with e2e tests related to changes. It's most likely my fault 😄 |
gziolo
force-pushed
the
update/block-view-scripts-handling
branch
from
9eeafb4
to
b796771
Compare
|
It looks like failing PHPUnit tests are related to the changes to the template editing mode in WP core, related PR: #32888. |
gziolo
force-pushed
the
update/block-view-scripts-handling
branch
from
b796771
to
89ba0a6
Compare
Resolved after rebase with It looks like failing e2e tests are completely unrelated to this branch after the fix added in 89ba0a6 for the tests covering Navigation block. |
vcanales
approved these changes
Jun 22, 2021
There was a problem hiding this comment.
Tested and it works as expected on the Navigation and File blocks. e2e test failures seem unrelated as well, as they're present in trunk at the moment.
Thanks for looking into this, this process is a great improvement.
youknowriad
pushed a commit
that referenced
this pull request
Jun 24, 2021
* Block Library: Unify handling for block view scripts * Add logic that registers view scripts for blocks * Fix e2e tests with view script for Navigation block
youknowriad
removed
the
Backport to WP 6.7 Beta/RC
youknowriad
pushed a commit
that referenced
this pull request
Jun 24, 2021
* Block Library: Unify handling for block view scripts * Add logic that registers view scripts for blocks * Fix e2e tests with view script for Navigation block
7 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Compatibility between the plugin and WordPress core
The following code won't work in WordPress core, because
plugins_urlscan only work with the Gutenberg plugin. We need a more general solution for core blocks to move forward:My proposal is that we only call
wp_enqueue_scriptwith the script handle and we register script separately outside of the PHP file that gets copied to WordPress core. This part is still missing in this PR.Rename
frontendtoviewBased on the feedback from @mtias, I included the change that promotes the name
viewfor the script to make it more general. The reasoning is that the output generated by blocks can be consumed not only the frontend part of WordPress but you could render them inside the WP-Admin.How has this been tested?
I tested with the Navigation block and its "Enable responsive menu" option enabled in the sidebar menu.
Once you insert the block, enable the option. It has to be tested on the front end on small viewports.
It should be tested also with the File block and embed previews for PDF files.
Screenshots
Types of changes
Bug fix (non-breaking change which fixes an issue).
Checklist:
*.native.jsfiles for terms that need renaming or removal).