Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add readme for SkipToSelectedBlock component #32958

Merged
merged 4 commits into from
Oct 16, 2021

Conversation

mikachan
Copy link
Member

Description

This PR adds a README.md as documentation for the SkipToSelectedBlock component (see #22891). I used the original PR for this component as a reference.

How has this been tested?

This change includes documentation only.

Types of changes

Documentation

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@mikachan mikachan requested a review from ellatrix as a code owner June 24, 2021 13:44
@github-actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @mikachan! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Jun 24, 2021
@MaggieCabrera MaggieCabrera added the [Type] Developer Documentation Documentation for developers label Jun 28, 2021
@MaggieCabrera MaggieCabrera requested a review from afercia June 28, 2021 09:24
Copy link
Member

@mkaz mkaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks so much for improving the documentation 👍
All looks good and makes sense.

@mkaz mkaz merged commit 39b4c96 into WordPress:trunk Oct 16, 2021
@github-actions github-actions bot added this to the Gutenberg 11.8 milestone Oct 16, 2021
@mikachan mikachan deleted the add/docs-skip-to-selected-block branch October 17, 2021 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants