Suppress block inserter focus loop #33049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces a setTimeout to suppress the focus loop issue that was uncovered by the block inserter search focus issue.
guarani
added
the
Mobile App - i.e. Android or iOS
|
Size Change: +421 B (0%) Total Size: 1.05 MB
ℹ️ View Unchanged
|
2 tasks
|
Admin tests failing, re-running ⏳ |
|
I gave this a quick test and it does seem to work ok. I do notice a slight delay between inserting a block and the keyboard focus moving to the new block. |
|
Admin tests still failing, re-running... |
jhnstn
approved these changes
Jun 30, 2021
once the tests pass
Awesome! I tested this as well on a physical iPhone 11 device:
All is looking good from my side too. |
|
Tests are still failing – I updated with the latest from |
|
Re-requesting a review now that we've addressed a VoiceOver issue that was discovered earlier. |
jhnstn
approved these changes
Jul 1, 2021
|
Re-running the admin tests, 🤞 they pass |
|
Re-running admin tests for the 5th time. |
|
Tests passed! 🥳 Merged |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses #30562 (suppresses bug instead of fixing it)
Related to wordpress-mobile/gutenberg-mobile#3681
This introduces a
setTimeoutto suppress the focus loop issue that was uncovered by the block inserter search focus issue.How has this been tested?
npm run start:reseta. With the cursor in a block that contains text, add a new block via the new block inserter search
b. Ensure that block selection and keyboard focus don't behave unexpectedly
Checklist:
*.native.jsfiles for terms that need renaming or removal).