Pattern Directory: Merge Core locale, caching updates #33052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iandunn
force-pushed
the
update/pattern-locales
branch
2 times, most recently
from
d83c6b7
to
52120d8
Compare
|
The workflow failures are just the e2e tests timing out, they even do that locally. Seems like that's normal lately 🤷🏻♂️ |
iandunn
force-pushed
the
update/pattern-locales
branch
from
52120d8
to
c3fe41f
Compare
iandunn
changed the title
|
Hi, @iandunn I think There were some issues with e2e tests, but I think rebase should fix it. |
iandunn
force-pushed
the
update/pattern-locales
branch
from
c3fe41f
to
869e58e
Compare
|
Ah, I only intended to backport the commits I made for https://core.trac.wordpress.org/ticket/53435. It looks like previous backports have rewritten Core code in a different way, and I don't have all the context about the "query" patterns, categories, etc. That makes it more difficult to backport other changes, but I've added the filter in 869e58e8. I've also rebased to fix the e2e tests. Beyond that, I'd prefer to keep the scope of this PR limited to the commits I have experience with, and let others backport anything they worked on. |
ryelle
reviewed
Jul 8, 2021
iandunn
commented
Jul 10, 2021
This information is needed by the w.org API for translation and caching. Merges https://core.trac.wordpress.org/changeset/51206 See https://core.trac.wordpress.org/ticket/53435 Co-authored-by: Dion Hulse <dion@wordpress.org> Co-authored-by: Kelly Dwan <ryelle@users.noreply.github.com> Co-authored-by: tellyworth <alex@automattic.com>
Now that the pattern API request includes the locale and version, the cache key needs to contain a hash of the query args. Merges https://core.trac.wordpress.org/changeset/51208 See https://core.trac.wordpress.org/ticket/53435 Co-authored-by: Dominik Schilling <ocean90@git.wordpress.org> Co-authored-by: Dion Hulse <dion@wordpress.org> Co-authored-by: Timothy Jacobs <timothyblynjacobs@git.wordpress.org>
The tests were failing in `wp-env` because the latest Core updates had not been backported, so they were disabled in WordPress#32228. Now that the updates are backported, the tests pass again.
…ter. The filter was added to Core during the process of syncing it with Gutenberg, but wasn't backported to Gutenberg until now. See https://core.trac.wordpress.org/ticket/53246 Co-authored-by: Kelly Dwan <ryelle@users.noreply.github.com>
iandunn
force-pushed
the
update/pattern-locales
branch
from
869e58e
to
1bafaa4
Compare
ryelle
approved these changes
Jul 13, 2021
12 tasks
getdave
added
the
[Feature] Pattern Directory
getdave
added
the
[Feature] Patterns
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Merges https://core.trac.wordpress.org/changeset/51206 and https://core.trac.wordpress.org/changeset/51208, so the bundled versions of Core files are up to date with Core
5.8-beta4Fixes #32754
How has this been tested?
Manual testing:
api.wordpress.orgto a w.org sandbox via/etc/hosts/(if applicable)pre_http_requestfilter, etc.Checklist:
*.native.jsfiles for terms that need renaming or removal).