components: Remove @emotion/css from ZStack
#33053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarayourfriend
added
[Type] Code Quality
sarayourfriend
requested review from
ajitbohra and
chrisvanpatten
as code owners
sarayourfriend
changed the title
@emotion/css from ZStack@emotion/css from ZStack
sarayourfriend
force-pushed
the
remove/emotion-css-z-stack
branch
from
69b41d2
to
32e1689
Compare
ciampo
approved these changes
Jun 30, 2021
| @@ -20,9 +16,7 @@ import { getValidChildren } from '../ui/utils/get-valid-children'; | |||
| import { contextConnect, useContextSystem } from '../ui/context'; | |||
| // eslint-disable-next-line no-duplicate-imports | |||
| import type { PolymorphicComponentProps } from '../ui/context'; | |||
| import { View } from '../view'; | |||
There was a problem hiding this comment.
Are we tracking the removal of the View component (and the createComponent function) anywhere?
There was a problem hiding this comment.
I think it will be removed as just a side effect of this work, I'm not sure it's necessary to track it separately.
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of #30503 (comment)
How has this been tested?
Storybook, everything all the props etc should all work as they worked before.
Types of changes
Non breaking change
Checklist:
*.native.jsfiles for terms that need renaming or removal).