components: Remove @emotion/css from Divider
#33054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarayourfriend
added
[Package] Components
sarayourfriend
requested review from
ajitbohra and
chrisvanpatten
as code owners
|
Size Change: +460 B (0%) Total Size: 1.05 MB
ℹ️ View Unchanged
|
sarayourfriend
force-pushed
the
remove/emotion-css-divider
branch
from
9b967ef
to
548e6d6
Compare
ciampo
requested changes
Jun 30, 2021
There was a problem hiding this comment.
The Storybook story seems to have some hiccups.
- When setting a value to one of the margin knobs, an error is printed to the console
- Another error is also printed when deleting/unsetting a value for the margin knobs
- If the
margin,marginTopandmarginBottomvalues are all set, themarginTopandmarginBottomvalues get ignored (as expected). But when themarginvalue is unset, themarginTopandmarginBottomvalues seem to be ignored
divider-storybook.mp4
I think all these issues come from storybook knobs defaulting to |
|
Yeah so the issue is that storybook's knobs are going from controlled to uncontrolled if we default the value to |
|
Although I'll add that I'm reluctant to change the code in the component to make the story work, it seems odd to do so. Maybe we should have two separate stories, one for just Actually yes I think that's the right answer. I'll update the story like so. |
|
Thank you for the explanation! Now that I remember, I did incur a similar/related problem when working on the Card component, and I solved it by using the |
ciampo
reviewed
Jun 30, 2021
Co-authored-by: Marco Ciampini <marco.ciampo@gmail.com>
ciampo
approved these changes
Jun 30, 2021
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of #30503 (comment)
I also updated the story so that it's easier to test.
How has this been tested?
Storybook, everything all the props etc should all work as they worked before (aside from the additional storybook knobs)
Types of changes
Non breaking change
Checklist:
*.native.jsfiles for terms that need renaming or removal).