Latest Posts block: Refactor to drop apiFetch usage in favor of using the data module #33063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Code Quality
|
Size Change: -6 B (0%) Total Size: 1.06 MB
ℹ️ View Unchanged
|
jorgefilipecosta
approved these changes
Jun 29, 2021
| @@ -377,7 +349,7 @@ export default function LatestPostsEdit( { attributes, setAttributes } ) { | |||
| '' !== value ? Number( value ) : undefined, | |||
| } ) | |||
| } | |||
| authorList={ authorList } | |||
| authorList={ authorList ?? [] } | |||
There was a problem hiding this comment.
Minor: Maybe we can use a shared EMPTY_ARRAY reference to avoid rerenders.
youknowriad
force-pushed
the
update/latest-posts-api-fetch
branch
from
1d94efb
to
e3eeb7f
Compare
sarayourfriend
pushed a commit
that referenced
this pull request
Jul 15, 2021
… the data module (#33063)
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm just continuing my refactors to remove the usage of apiFetch in block-library and editor packages to make these two packages WP-agnostic (considering the data module an adaptable interface to any backend)
Testing instructions