Fix slash command focus style. #33084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Type] Bug
|
Size Change: -7 B (0%) Total Size: 1.05 MB
ℹ️ View Unchanged
|
|
Thank you! There are some failing tests that are unrelated, so I will wait for them to be fixed in trunk, then rebase, before I merge. |
|
I restarted the tests. I think the pattern issue should be fixed for now. Let's hope others don't fail 🤞 |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #23718.
The focus style width variable was not used in the auto complete component, meaning it was wrong:
This PR makes it right:
I also verified that the border radius is correct compared to other elements.
How has this been tested?
Use the slash command and verify the focus style is right.
Checklist:
*.native.jsfiles for terms that need renaming or removal).