-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Button: Remove green background color in button preview #33116
Conversation
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @walbo! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
Thanks for including screenshots and the PR; I didn't realize this would be such an easy fix! I've tested this on a block-based theme (hansen) and the green color background is removed. |
I have also tested it on a couple of custom themes and havn't found any issues with the fix. |
I found no issues testing this on a few custom themes. This seems like the way it ought to be 👍 . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works as expected. Thanks for the contribution, @walbo.
Description
Remove the green background color in the button example. The button will then use the default button color. This will also make the style from the theme match the preview.
Fixes #21954
How has this been tested?
Locally with different bundled themes.
Screenshots
Types of changes
Bug fix
Checklist:
*.native.js
files for terms that need renaming or removal).