Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button: Remove green background color in button preview #33116

Merged
merged 2 commits into from
Jul 12, 2021

Conversation

walbo
Copy link
Member

@walbo walbo commented Jun 30, 2021

Description

Remove the green background color in the button example. The button will then use the default button color. This will also make the style from the theme match the preview.

Fixes #21954

How has this been tested?

Locally with different bundled themes.

Screenshots

button-green-fix

Types of changes

Bug fix

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@walbo walbo requested a review from ajitbohra as a code owner June 30, 2021 21:03
@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Jun 30, 2021
@github-actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @walbo! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@walbo walbo changed the title Button: Remove green background color from button preview Button: Remove green background color in button preview Jun 30, 2021
@skorasaurus skorasaurus added the [Block] Buttons Affects the Buttons Block label Jul 2, 2021
@skorasaurus
Copy link
Member

Thanks for including screenshots and the PR; I didn't realize this would be such an easy fix!

I've tested this on a block-based theme (hansen) and the green color background is removed.

@walbo
Copy link
Member Author

walbo commented Jul 6, 2021

I have also tested it on a couple of custom themes and havn't found any issues with the fix.

@stokesman
Copy link
Contributor

I found no issues testing this on a few custom themes. This seems like the way it ought to be 👍 .

Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works as expected. Thanks for the contribution, @walbo.

@Mamaduka Mamaduka added [Type] Bug An existing feature does not function as intended and removed First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository labels Jul 12, 2021
@Mamaduka Mamaduka merged commit 28db73d into WordPress:trunk Jul 12, 2021
@github-actions github-actions bot added this to the Gutenberg 11.1 milestone Jul 12, 2021
@walbo walbo deleted the fix-green-button-example branch July 12, 2021 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Buttons Affects the Buttons Block [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Button preview doesn't match styling
4 participants