Fix inserter size on widgets screen header #33118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tellthemachines
requested review from
adamziel,
draganescu,
kevin940726,
noisysocks and
talldan
as code owners
tellthemachines
added
[Feature] Widgets Screen
|
Size Change: +2 B (0%) Total Size: 1.05 MB
ℹ️ View Unchanged
|
Good to know, thanks :) |
kevin940726
approved these changes
Jul 1, 2021
| > .components-button.has-icon, | ||
| > .components-dropdown > .components-button.has-icon { | ||
| // Specificity bump needed to offset https://github.com/WordPress/gutenberg/blob/8ea29cb04412c80c9adf7c1db0e816d6a0ac1232/packages/components/src/toolbar/style.scss#L76 | ||
| > .components-button.has-icon.has-icon.has-icon, |
There was a problem hiding this comment.
Is it necessary to add it 3 times?
There was a problem hiding this comment.
The rule we're overriding has 4 classnames, so I thought it would be best to have 5 to be on the safe side 😅
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #33061 by increasing specificity of Widgets screen inserter selectors.
Note: this shouldn't need to be backported to Core as the change that caused the issue wasn't backported either.
How has this been tested?
Go to Widgets screen, check inserter in the header is the correct size (36x36 px)
Screenshots
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist:
*.native.jsfiles for terms that need renaming or removal).