-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable previously skipped widgets tests #33121
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin940726
added
the
[Feature] Widgets Screen
The block-based screen that replaced widgets.php.
label
Jul 1, 2021
Size Change: 0 B Total Size: 1.05 MB ℹ️ View Unchanged
|
kevin940726
force-pushed
the
try/enable-skipped-widgets-tests
branch
from
July 1, 2021 02:45
4550e31
to
fc5989b
Compare
kevin940726
requested review from
talldan,
tellthemachines,
adamziel,
noisysocks,
draganescu and
getdave
and removed request for
ntwb,
ajitbohra and
nerrad
July 1, 2021 03:17
noisysocks
approved these changes
Jul 1, 2021
Would be good to do a little audit and make sure we're testing:
|
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Widgets screen is getting matured and stable, we can start enable some previously skipped e2e tests and try to catch bugs if any. This PR enables:
How has this been tested?
e2e tests should pass
Types of changes
Bug fix
Checklist:
*.native.js
files for terms that need renaming or removal).